Message122067
Raymond: I made a single diff for easier review. I’m not 100% sure I should change 'r' to 'rb' in logging: It’s unrelated to with, and the rest of the file has not been checked for similar errors. I prefer to do commits that don’t mix things.
Eli:
> which whitespace change do you refer to. I changed to 4-spaces
> indentation in the code sample to conform to PEP-8. Shouldn't I have?
PEP 8 only applies to Python code. http://docs.python.org/dev/documenting/style applies to the docs. |
|
Date |
User |
Action |
Args |
2010-11-22 02:21:42 | eric.araujo | set | recipients:
+ eric.araujo, georg.brandl, rhettinger, terry.reedy, belopolsky, ezio.melotti, eli.bendersky, SilentGhost, docs@python |
2010-11-22 02:21:42 | eric.araujo | set | messageid: <1290392502.51.0.898255418006.issue10461@psf.upfronthosting.co.za> |
2010-11-22 02:21:37 | eric.araujo | link | issue10461 messages |
2010-11-22 02:21:37 | eric.araujo | create | |
|