This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author techtonik
Recipients eric.araujo, tarek, techtonik
Date 2010-11-09.08:51:32
SpamBayes Score 8.344884e-06
Marked as misclassified No
Message-id <20cf30549ad507f12004949a88b3@google.com>
In-reply-to
Content
Fixed docstring.

http://codereview.appspot.com/2874041/diff/2001/cmd.py
File cmd.py (right):

http://codereview.appspot.com/2874041/diff/2001/cmd.py#newcode55
cmd.py:55: :param distutils.dist.Distribution dist: distribution to work
with
On 2010/11/08 18:47:39, merwok wrote:
> > Including this in another patch is too much work to ever happen.
> We’ll have to revert it before committing then.

> > What Python uses?
> Something like “*dist* is an instance of blah”.

I thought Python uses all Sphinx capabilities. Done.

http://codereview.appspot.com/2874041/diff/2001/command/upload.py
File command/upload.py (right):

http://codereview.appspot.com/2874041/diff/2001/command/upload.py#newcode53
command/upload.py:53: if not self.username and
self.distribution.username:
On 2010/11/08 18:47:39, merwok wrote:
> This is a crazy case.

That's why I don't want to make distinction between "None" username and
empty username. They are both the same in this context.

http://codereview.appspot.com/2874041/diff/2001/tests/test_register.py
File tests/test_register.py (right):

http://codereview.appspot.com/2874041/diff/2001/tests/test_register.py#newcode165
tests/test_register.py:165: inputs = RawInputs('1', 'tarek', 'n')
On 2010/11/08 18:47:39, merwok wrote:
> It looks like you’re replying to “username” and “save your login” but
not
> “password”.

That's magically patched in setUp method.

http://codereview.appspot.com/2874041/
History
Date User Action Args
2011-02-09 22:47:03eric.araujounlinkissue10361 messages
2010-11-09 08:51:38techtoniksetrecipients: + techtonik
2010-11-09 08:51:34techtoniklinkissue10361 messages
2010-11-09 08:51:32techtonikcreate