Message120223
+1
I agree on removing the lowercase versions. It's sort of handy having them around to prevent accidental uses. But the same could be said for other similar macros/functions. Plus they wouldn't work if the isXXX symbols were really functions, not macros (not that I know if that's even allowed by the standard).
The patch looks okay to me, although I didn't actually compile and run the tests. You'll find out soon enough! The issue number in the NEWS entry needs to be fixed, of course.
Thanks for doing this, Dave. |
|
Date |
User |
Action |
Args |
2010-11-02 13:51:11 | eric.smith | set | recipients:
+ eric.smith, lemburg, mark.dickinson, dmalcolm |
2010-11-02 13:51:11 | eric.smith | set | messageid: <1288705871.11.0.269106444809.issue10288@psf.upfronthosting.co.za> |
2010-11-02 13:51:09 | eric.smith | link | issue10288 messages |
2010-11-02 13:51:09 | eric.smith | create | |
|