Message117364
I found a a useless lock acquiring in the 27 maintenance branch in logging and a missing one as well:
Logger.removeHandler() locks around a handler lock, however the code executed in this lock is not depending on anything of that lock. However there is a race condition when two pieces of code try to remove the same handler at the same time because between the if and the remove() no locking takes place.
I would recommend this instead (and also add locking to the addHandler):
def addHandler(self, hdlr):
"""
Add the specified handler to this logger.
"""
_acquireLock()
try:
if hdlr not in self.handlers:
self.handlers.append(hdlr)
finally:
_releaseLock()
def removeHandler(self, hdlr):
"""
Remove the specified handler from this logger.
"""
_acquireLock()
try:
if hdlr in self.handlers:
self.handlers.remove(hdlr)
finally:
_releaseLock()
I suppose in 3.x there might be something similar. |
|
Date |
User |
Action |
Args |
2010-09-25 13:27:33 | aronacher | set | recipients:
+ aronacher, vinay.sajip |
2010-09-25 13:27:33 | aronacher | set | messageid: <1285421253.55.0.777992318976.issue9945@psf.upfronthosting.co.za> |
2010-09-25 13:27:31 | aronacher | link | issue9945 messages |
2010-09-25 13:27:30 | aronacher | create | |
|