This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author dmalcolm
Recipients dmalcolm, pitrou
Date 2010-09-08.20:57:01
SpamBayes Score 2.8459658e-08
Marked as misclassified No
Message-id <1283979430.13.0.88892179187.issue9188@psf.upfronthosting.co.za>
In-reply-to
Content
One minor quibble with the patch:

In the line:
   while i < field_length:
you're trusting that field_length has a sane value.  If field_str points somewhere readable, and field_length is huge (e.g. 0xfffffff), then gdb could sit there for a while reading all that data until it either completes, or hits memory that it can't read (leading to a python exception within gdb).

In other places in that code I used safe_range() to limit iterations to a safety threshold; I suggest the use of
  safety_limit(field_length)

But this is a minor nit.


I don't think this
History
Date User Action Args
2010-09-08 20:57:10dmalcolmsetrecipients: + dmalcolm, pitrou
2010-09-08 20:57:10dmalcolmsetmessageid: <1283979430.13.0.88892179187.issue9188@psf.upfronthosting.co.za>
2010-09-08 20:57:02dmalcolmlinkissue9188 messages
2010-09-08 20:57:01dmalcolmcreate