Message114084
The calls to Py_GetFinalPathNameByHandle come in pairs: one to get the length, the other to retrieve the value. They should at least be consistent.
There are two other issues:
- in all three places, it's possible for the function to return after malloc(), but before the call to free(); and PyMem_Malloc()/PyMem_Free() would be better.
- on my windows XP, os.stat() is slower than before, and is now significantly slower than os.lstat() (26.6 usec -> 32.8 usec); I found that check_GetFinalPathNameByHandle() repeatedly checks for the presence of the function, and always calls GetModuleHandle() and GetProcAddress(). The attached patch fixes this, can you test it on Vista? |
|
Date |
User |
Action |
Args |
2010-08-16 23:24:12 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, rhettinger, jaraco, brian.curtin |
2010-08-16 23:24:11 | amaury.forgeotdarc | set | messageid: <1282001051.62.0.649091707456.issue9445@psf.upfronthosting.co.za> |
2010-08-16 23:23:59 | amaury.forgeotdarc | link | issue9445 messages |
2010-08-16 23:23:59 | amaury.forgeotdarc | create | |
|