Message111769
There are a couple of things that I don't like in the patch:
1) raising a TypeError with a proper message seems better than raising an AttributeError (maybe check if not isinstance(string, (str, bytes)): raise TypeError(...)?);
2) from the snippet I see in the patch, ISTM that unquote_to_bytes accepts both bytes and strings and returns always bytes but unquote might return both bytes and strings (I'm not aware of the design decisions behind these API, but this looks at least inconsistent and maybe wrong (shouldn't it only accept one type?)). |
|
Date |
User |
Action |
Args |
2010-07-28 04:06:42 | ezio.melotti | set | recipients:
+ ezio.melotti, orsenthil, djc, eric.araujo, flox, ysj.ray |
2010-07-28 04:06:42 | ezio.melotti | set | messageid: <1280290002.63.0.432939495715.issue9301@psf.upfronthosting.co.za> |
2010-07-28 04:06:40 | ezio.melotti | link | issue9301 messages |
2010-07-28 04:06:40 | ezio.melotti | create | |
|