This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ezio.melotti
Recipients djc, eric.araujo, ezio.melotti, flox, orsenthil, ysj.ray
Date 2010-07-28.04:06:40
SpamBayes Score 0.0007981132
Marked as misclassified No
Message-id <1280290002.63.0.432939495715.issue9301@psf.upfronthosting.co.za>
In-reply-to
Content
There are a couple of things that I don't like in the patch:
  1) raising a TypeError with a proper message seems better than raising an AttributeError (maybe check if not isinstance(string, (str, bytes)): raise TypeError(...)?);
  2) from the snippet I see in the patch, ISTM that unquote_to_bytes accepts both bytes and strings and returns always bytes but unquote might return both bytes and strings (I'm not aware of the design decisions behind these API, but this looks at least inconsistent and maybe wrong (shouldn't it only accept one type?)).
History
Date User Action Args
2010-07-28 04:06:42ezio.melottisetrecipients: + ezio.melotti, orsenthil, djc, eric.araujo, flox, ysj.ray
2010-07-28 04:06:42ezio.melottisetmessageid: <1280290002.63.0.432939495715.issue9301@psf.upfronthosting.co.za>
2010-07-28 04:06:40ezio.melottilinkissue9301 messages
2010-07-28 04:06:40ezio.melotticreate