This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author brian.curtin
Recipients brian.curtin, michael.foord
Date 2010-07-22.17:11:16
SpamBayes Score 5.850127e-05
Marked as misclassified No
Message-id <1279818680.38.0.509759364598.issue9330@psf.upfronthosting.co.za>
In-reply-to
Content
A recent sysconfig test which should have been skipped on Windows (now fixed) exposed a bug in the assertIn/assertNotIn methods. If the "container" you are testing doesn't support membership testing or iteration, such as None value when a previous call fails, the test is then an error rather than a fail.

Before:
======================================================================
ERROR: test_ldshared_value (test.test_sysconfig.TestSysConfig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "c:\python-dev\py3k\lib\test\test_sysconfig.py", line 285, in test_ldshar
ed_value
    self.assertIn(ldflags, ldshared)
  File "c:\python-dev\py3k\lib\unittest\case.py", line 797, in assertIn
    if member not in container:
TypeError: argument of type 'NoneType' is not iterable


I believe this should be a fail with AssertionError, rather than an error with TypeError.

======================================================================
FAIL: test_ldshared_value (test.test_sysconfig.TestSysConfig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "c:\python-dev\py3k\lib\test\test_sysconfig.py", line 285, in test_ldshar
ed_value
    self.assertIn(ldflags, ldshared)
AssertionError: None does not support the `in` operator



The patch adds a check that __contains__, __iter__, or __getitem__ exist on the object and fails the test if none of those are found. It also includes a few test updates.
History
Date User Action Args
2010-07-22 17:11:20brian.curtinsetrecipients: + brian.curtin, michael.foord
2010-07-22 17:11:20brian.curtinsetmessageid: <1279818680.38.0.509759364598.issue9330@psf.upfronthosting.co.za>
2010-07-22 17:11:18brian.curtinlinkissue9330 messages
2010-07-22 17:11:17brian.curtincreate