This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jbit
Recipients jbit, r.david.murray, vstinner
Date 2010-07-13.15:44:05
SpamBayes Score 0.0001204978
Marked as misclassified No
Message-id <1279035847.46.0.923612451045.issue9243@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the update... The link was actually just a "diff to previous" of the changelist that caused the problem (r56987), sorry for the confusion. :)

Attached is a quick and dirty unittest complete with some test files. It only tests the format of the file though, not any of the additional information returned.

With an untouched sndhdr.py it finds the issue reported, and with sndhdr-fix.patch applied it reports only one issue:

Traceback (most recent call last):
  File "test_sndhdr.py", line 22, in test_aiff
    self.assertEqual(ret[0], 'aiff')
AssertionError: b'aiff' != 'aiff'

I'm thinking that on line 65 of sndhdr.py the b'aiff' should be just 'aiff' (like everything else). At least I can't see a reason for it to be different. (Changing this fixes the unittest issue)

Cheers
History
Date User Action Args
2010-07-13 15:44:08jbitsetrecipients: + jbit, vstinner, r.david.murray
2010-07-13 15:44:07jbitsetmessageid: <1279035847.46.0.923612451045.issue9243@psf.upfronthosting.co.za>
2010-07-13 15:44:06jbitlinkissue9243 messages
2010-07-13 15:44:05jbitcreate