Message110196
> I wasn't really precise. The test fails on Linux, but for a different reason.
> Linux legitimately sets ENAMETOOLONG and raises OSError. This only becomes
> apparent when using 4098 in the test.
>
> Solaris, on the other hand, does not even raise, since it keeps setting
> ERANGE and thus does not leave the loop in posix_getcwd(). IOW, only the
> fix in posixmodule.c allows the test to fail properly in the first place.
Ok. Still, silencing all OSErrors in test_posix is much too broad. The
code should check for expected error codes, possibly depending on the
OS.
> If you prefer, of course it's possible to be conservative and make the new
> version of posix_getcwd() Solaris specific.
I think this would be the most reasonable solution for 2.7, indeed. |
|
Date |
User |
Action |
Args |
2010-07-13 14:01:01 | pitrou | set | recipients:
+ pitrou, csernazs, skrah |
2010-07-13 14:00:57 | pitrou | link | issue9185 messages |
2010-07-13 14:00:57 | pitrou | create | |
|