Message109204
I agree that help(None) should return help on None but suggest a change to the patch.
I understand that the point of changing
- def __call__(self, request=None):
to the somewhat opaque
+ def __call__(self, *args):
+ try:
+ request, = args
+ except ValueError:
is to make help() work the same as now without defaulting request to None. However, I believe that it will change help(1,2) to being the same as help() instead raising TypeError. I do not think that that API change is desirable. This can be avoided by instead creating a private sentinel. The alternate replacement would be
+ __GoInteractive = object()
+ def __call__(self, request=__GoInteractive):
+ if request is not __GoInteractive:
- if request is not None:
with the rest of code the unchanged. |
|
Date |
User |
Action |
Args |
2010-07-04 03:55:14 | terry.reedy | set | recipients:
+ terry.reedy, belopolsky, jackdied |
2010-07-04 03:55:14 | terry.reedy | set | messageid: <1278215714.46.0.106798732762.issue9118@psf.upfronthosting.co.za> |
2010-07-04 03:55:13 | terry.reedy | link | issue9118 messages |
2010-07-04 03:55:12 | terry.reedy | create | |
|