This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients ezio.melotti, mark.dickinson, skrah, ubershmekel
Date 2010-07-01.18:47:11
SpamBayes Score 0.081229426
Marked as misclassified No
Message-id <1278010034.76.0.599804396641.issue9136@psf.upfronthosting.co.za>
In-reply-to
Content
Nice shade of blue!  Just a couple of red spots that I'd prefer repainted, namely: (1) please put bodies of 'try:' and 'except:' on separate lines, and (2) please use 'except NameError' instead of a bare except.

And a couple of points that I think also applied to my patch:

- {s: 0 for s in _signals} could also be spelt dict.fromkeys(_signals, 0)

- I think dict(dc.traps) should be dc.traps.copy() instead.  I can't entirely see why it would matter, except that it's conceivable that dc.traps could by a dict subclass with its own copy method.
History
Date User Action Args
2010-07-01 18:47:14mark.dickinsonsetrecipients: + mark.dickinson, ezio.melotti, ubershmekel, skrah
2010-07-01 18:47:14mark.dickinsonsetmessageid: <1278010034.76.0.599804396641.issue9136@psf.upfronthosting.co.za>
2010-07-01 18:47:12mark.dickinsonlinkissue9136 messages
2010-07-01 18:47:12mark.dickinsoncreate