Message109066
Nice shade of blue! Just a couple of red spots that I'd prefer repainted, namely: (1) please put bodies of 'try:' and 'except:' on separate lines, and (2) please use 'except NameError' instead of a bare except.
And a couple of points that I think also applied to my patch:
- {s: 0 for s in _signals} could also be spelt dict.fromkeys(_signals, 0)
- I think dict(dc.traps) should be dc.traps.copy() instead. I can't entirely see why it would matter, except that it's conceivable that dc.traps could by a dict subclass with its own copy method. |
|
Date |
User |
Action |
Args |
2010-07-01 18:47:14 | mark.dickinson | set | recipients:
+ mark.dickinson, ezio.melotti, ubershmekel, skrah |
2010-07-01 18:47:14 | mark.dickinson | set | messageid: <1278010034.76.0.599804396641.issue9136@psf.upfronthosting.co.za> |
2010-07-01 18:47:12 | mark.dickinson | link | issue9136 messages |
2010-07-01 18:47:12 | mark.dickinson | create | |
|