Message 108148 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	loewis
Recipients	eric.smith, loewis, r.david.murray, srid
Date	2010-06-18.23:02:26
SpamBayes Score	0.016843513
Marked as misclassified	No
Message-id	<1276902148.54.0.0520306246326.issue9020@psf.upfronthosting.co.za>
In-reply-to

Content
> Does anyone know what other compilers use signed chars? Most of them do, including gcc, on most platforms. unsigned char is really the uncommon case. The patch is incorrect; Py_CHARMASK is correct as it stands. It is not the objective of Py_CHARMASK to produce a char, but (as the comment above its definition explains) to produce an int. The question really is why you get a value of -1 into c in the first place. Could it be that you are past the end of file, and reading EOF "characters"?

> Does anyone know what other compilers use signed chars?

Most of them do, including gcc, on most platforms. unsigned char is really the uncommon case.

The patch is incorrect; Py_CHARMASK is correct as it stands. It is *not* the objective of Py_CHARMASK to produce a char, but (as the comment above its definition explains) to produce an int.

The question really is why you get a value of -1 into c in the first place. Could it be that you are past the end of file, and reading EOF "characters"?

History
Date	User	Action	Args
2010-06-18 23:02:28	loewis	set	recipients: + loewis, eric.smith, r.david.murray, srid
2010-06-18 23:02:28	loewis	set	messageid: <1276902148.54.0.0520306246326.issue9020@psf.upfronthosting.co.za>
2010-06-18 23:02:26	loewis	link	issue9020 messages
2010-06-18 23:02:26	loewis	create