Message108139
On 2010-06-18, at 11:47 AM, Eric Smith wrote:
>
> Eric Smith <eric@trueblade.com> added the comment:
>
> I suppose that's correct, although I have no way to test it.
I have tested it on Linux 64-bit by running `test.regrtest`. It doesn't seem to break anything.
> I haven't spent a lot of time looking at the code in tokenizer.c, but if there's a problem with sign-extending signed chars, it wouldn't surprise me if it shows up in more than one place.
My conclusive understanding of the problem: `register int` is 4 bytes in size, and this (`c`) is used without any cast as an index to the array _Py_ctype_table (in pyctype.c) ... by passing it to `Py_CHARMASK` which, if CHAR_UNSIGNED is defined (as is the case with AIX compiler), *assumes* that `c` will always be a char. And that assumption is not respected by tokenizer.c:tok_get which (indirectly) passes `register int` to this macro. |
|
Date |
User |
Action |
Args |
2010-06-18 20:47:29 | srid | set | recipients:
+ srid, loewis, eric.smith, r.david.murray |
2010-06-18 20:47:26 | srid | link | issue9020 messages |
2010-06-18 20:47:26 | srid | create | |
|