This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author belopolsky
Recipients belopolsky, brett.cannon, loewis, mark.dickinson
Date 2010-06-16.15:46:51
SpamBayes Score 0.00023875677
Marked as misclassified No
Message-id <1276703214.18.0.763658156575.issue9012@psf.upfronthosting.co.za>
In-reply-to
Content
Here is the history of the issue per Martin v. Löwis on python-dev:

"""

This was added with

------------------------------------------------------------------------
r36221 | bcannon | 2004-06-24 03:38:47 +0200 (Do, 24. Jun 2004) | 3 Zeilen

Add compilation of timemodule.c with datetimemodule.c to get
__PyTime_DoubleToTimet().

------------------------------------------------------------------------

So it's clearly intentional. I doubt its desirable, though. If only
__PyTime_DoubleToTimet needs to be duplicated, I'd rather put that
function into a separate C file that gets included twice, instead of including the full timemodule.c into datetimemodule.c.
"""
-- "Sharing functions between C extension modules in stdlib", http://mail.python.org/pipermail/python-dev/2010-June/100587.html

I hope this is non-controversial, but I would like someone to comment on the choice of file name.  I chose _timefunc.c to make it more distinguishable from module file names.  Ideally, however I would like to see this in either _time.h/_time.c pair (both in Module dir like _math.{c,h}) or in pytime.h/pytime.c (like pymath.{c,h}).

Marking this as "resource usage" because the patch will result in smaller size of datetime module.
History
Date User Action Args
2010-06-16 15:46:54belopolskysetrecipients: + belopolsky, loewis, brett.cannon, mark.dickinson
2010-06-16 15:46:54belopolskysetmessageid: <1276703214.18.0.763658156575.issue9012@psf.upfronthosting.co.za>
2010-06-16 15:46:52belopolskylinkissue9012 messages
2010-06-16 15:46:51belopolskycreate