Message105774
I think if the test is conducted without closing stderr, it will only check that stdin/stdout are handled correctly (you could assume that if one handled stdin/stdout correctly, they did the same with stderr).
However, since I've used a context manager (_NoStandardFds) to handle the closing/restoration of the standard fds, I think the benefit (fuller test coverage) outweighs the cost (potentially harder debugging if there's a problem with the test); if I'm not mistaken, the context manager should restore your fds before the default exception handler writes to stdout (at least in the parent and the child prior to exec()).
n.b.: I've also created a Rietveld issue for this patch: http://codereview.appspot.com/1227041/show |
|
Date |
User |
Action |
Args |
2010-05-14 22:16:37 | Yaniv.Aknin | set | recipients:
+ Yaniv.Aknin, gregory.p.smith, astrand, pitrou, christian.heimes |
2010-05-14 22:16:37 | Yaniv.Aknin | set | messageid: <1273875397.8.0.200812881784.issue6610@psf.upfronthosting.co.za> |
2010-05-14 22:16:36 | Yaniv.Aknin | link | issue6610 messages |
2010-05-14 22:16:35 | Yaniv.Aknin | create | |
|