Author stutzbach
Recipients belopolsky, draghuram, mark.dickinson, rhettinger, stutzbach
Date 2010-05-13.22:09:05
SpamBayes Score 0.00553642
Marked as misclassified No
Message-id <1273788547.25.0.612184566517.issue8692@psf.upfronthosting.co.za>
In-reply-to
Content
Speaking of getting side-tracked, I didn't see an answer to a question I asked earlier.  I'd like to get some feedback before I proceed with revising the patch.

For the find-last-set-bit (to replace log2) and count-set-bits operations, would it be worthwhile to create a pybits.h and .c that defines _Py_FindLastSetBit and _Py_CountSetBits? (with appropriate logic in the .h and configure.in to use system/compiler versions if available)

There are already two implementations of find-last-set-bit in Python:
bits_in_digit() in Objects/longobject.c and hi0bits() in Python/dtoa.c, which I could consolidate.

Alternately, I could just add static functions to mathmodule.c with the simplest possible implementation (they're only called once per factorial, so the performance impact is minimal).
History
Date User Action Args
2010-05-13 22:09:07stutzbachsetrecipients: + stutzbach, rhettinger, mark.dickinson, belopolsky, draghuram
2010-05-13 22:09:07stutzbachsetmessageid: <1273788547.25.0.612184566517.issue8692@psf.upfronthosting.co.za>
2010-05-13 22:09:06stutzbachlinkissue8692 messages
2010-05-13 22:09:05stutzbachcreate