Author pitrou
Recipients aerodonkey, neologix, orsenthil, pitrou, santoso.wijaya
Date 2010-04-26.10:45:54
SpamBayes Score 3.83647e-08
Marked as misclassified No
Message-id <1272278887.3539.10.camel@localhost>
In-reply-to <1272278265.13.0.264125466675.issue6085@psf.upfronthosting.co.za>
Content
> And for this specific request, it fdqn is looked up only for "logging"
> to sys.stderr. Either removing the fqdn call or just caching per
> connection it as the patch does is both fine. I doubt if someone is
> relying this logging anywhere in the code. This is useful only when
> BaseHTTPServer is started in the command like as a standalone HTTP
> server.

I think we should totally remove the call to fqdn. The common practice
with HTTP servers is to log numeric IPs and, if desired, let a batch log
analysis process (such as awstats) deal with DNS resolution and caching.

> And there is not testing code present (or required too - as this is a
> cli invocation scenario).

What do you mean? BaseHTTPRequestHandler is tested in test_httpservers.
History
Date User Action Args
2010-04-26 10:45:56pitrousetrecipients: + pitrou, orsenthil, aerodonkey, neologix, santoso.wijaya
2010-04-26 10:45:54pitroulinkissue6085 messages
2010-04-26 10:45:54pitroucreate