Message103794
Some comments:
- your ssl_convert_filename() function has a strange signature
- using PyByteArray_AsString() is wrong, we release the GIL later and the buffer could be reallocated, leading to a crash; the right approach is to use PyObject_GetBuffer() and later PyBuffer_Release()
- as such, your function could simply return the bytes/bytearray PyObject *, and not fill the char * pointer
- adding tests for both the bytes and unicode cases would be nice |
|
Date |
User |
Action |
Args |
2010-04-20 23:45:40 | pitrou | set | recipients:
+ pitrou, vstinner |
2010-04-20 23:45:39 | pitrou | set | messageid: <1271807139.9.0.378140861036.issue8477@psf.upfronthosting.co.za> |
2010-04-20 23:45:38 | pitrou | link | issue8477 messages |
2010-04-20 23:45:38 | pitrou | create | |
|