Message103659
> The last line references, buf. It wont be available if a
> socket.timeout had happened. So, it can simply be moved to
> the line below buf = f.read(). Attaching the patch with
> these changes.
Good catch :-)
> Question: Were you able to simulate a timeout at kernel.org
> site to test this? If yes, how?
I used a firewall rule. On Linux, you can try: iptables -I OUTPUT DROP to drop all output packets (and then iptables -F to remove all rules). It's not reliable, but the test does sometimes fail :-) |
|
Date |
User |
Action |
Args |
2010-04-19 23:23:06 | vstinner | set | recipients:
+ vstinner, orsenthil |
2010-04-19 23:23:06 | vstinner | set | messageid: <1271719386.16.0.90692709375.issue8460@psf.upfronthosting.co.za> |
2010-04-19 23:23:04 | vstinner | link | issue8460 messages |
2010-04-19 23:23:04 | vstinner | create | |
|