This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author techtonik
Recipients georg.brandl, techtonik
Date 2010-04-14.18:53:43
SpamBayes Score 1.762347e-07
Marked as misclassified No
Message-id <1271271228.07.0.394699354264.issue8399@psf.upfronthosting.co.za>
In-reply-to
Content
On Unix all files are opened in binary mode. On Windows linefeeds are translated to CRLF corrupting files that are meant to be binary. This is the reason of HgGit failure - it uses Dulwich library that creates corrupted Git index file, because on Windows it is opened without os.O_BINARY flag. Developers do not know anything about it, because they develop on Unix. This could be prevented if we supply a note about how to preserve crossplatform behavior.
https://bugs.edge.launchpad.net/dulwich/+bug/557585

I've attached a patch that adds required note. Please revise it. It should clearly apply over your changes in r80069. I reworded description towards Python users without C background, but I am still worried that they need a POSIX background to understand umask part.
History
Date User Action Args
2010-04-14 18:53:48techtoniksetrecipients: + techtonik, georg.brandl
2010-04-14 18:53:48techtoniksetmessageid: <1271271228.07.0.394699354264.issue8399@psf.upfronthosting.co.za>
2010-04-14 18:53:45techtoniklinkissue8399 messages
2010-04-14 18:53:44techtonikcreate