Message102628
From Juan Lang, who originally pointed out the bug:
My only comment is that the message is now misleading:
- individual_group_bit = (node >> 40L) & 1
- universal_local_bit = (node >> 40L) & 2
message = "%012x doesn't look like a real MAC address" % node
- self.assertEqual(individual_group_bit, 0, message)
- self.assertEqual(universal_local_bit, 0, message)
self.assertNotEqual(node, 0, message)
self.assertNotEqual(node, 0xffffffffffffL, message)
The test no longer checks for the uuid being a MAC address or not.
Ideally it would be reworded to be less confusing, or perhaps the code
could check the various "flavors" of uuids, and check that a generated
uuid conforms to one of them. |
|
Date |
User |
Action |
Args |
2010-04-08 16:48:28 | austin987 | set | recipients:
+ austin987, skrah |
2010-04-08 16:48:28 | austin987 | set | messageid: <1270745308.27.0.537238153455.issue7650@psf.upfronthosting.co.za> |
2010-04-08 16:48:24 | austin987 | link | issue7650 messages |
2010-04-08 16:48:23 | austin987 | create | |
|