Message 102072 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	ncoghlan
Recipients	Arfrever, amaury.forgeotdarc, arekm, michael.foord, ncoghlan, pitrou, r.david.murray, valerio.turturici
Date	2010-04-01.07:58:24
SpamBayes Score	9.20375e-06
Marked as misclassified	No
Message-id	<1270108707.92.0.327934296449.issue8193@psf.upfronthosting.co.za>
In-reply-to

Content
The "I'm not sure" in my comment really was a question, rather than a definite direction to conditionally retain the old test. I've actually looked at the relevant C code in the zlib module now, and I agree with Antoine that the original suggestion of changing the 0 in the test to a -1 is fine (the test is just checking the handling of a Z_STREAM_ERROR return from the API call rather than anything more sophisticated). Adding to my to-do list.

The "I'm not sure" in my comment really was a question, rather than a definite direction to conditionally retain the old test.

I've actually looked at the relevant C code in the zlib module now, and I agree with Antoine that the original suggestion of changing the 0 in the test to a -1 is fine (the test is just checking the handling of a Z_STREAM_ERROR return from the API call rather than anything more sophisticated).

Adding to my to-do list.

History
Date	User	Action	Args
2010-04-01 07:58:29	ncoghlan	set	recipients: + ncoghlan, amaury.forgeotdarc, arekm, pitrou, Arfrever, r.david.murray, michael.foord, valerio.turturici
2010-04-01 07:58:27	ncoghlan	set	messageid: <1270108707.92.0.327934296449.issue8193@psf.upfronthosting.co.za>
2010-04-01 07:58:26	ncoghlan	link	issue8193 messages
2010-04-01 07:58:24	ncoghlan	create