Message 101923 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	ncoghlan
Recipients	Arfrever, amaury.forgeotdarc, arekm, ncoghlan, r.david.murray, valerio.turturici
Date	2010-03-30.09:10:30
SpamBayes Score	1.4754664e-10
Marked as misclassified	No
Message-id	<1269940232.05.0.059681088919.issue8193@psf.upfronthosting.co.za>
In-reply-to

Content
I'm not sure simply changing the value is the right thing to do - with older zlib versions (which do the wrong thing with 0), we definitely want that exception to be triggered. For newer versions, we want to check that passing in 0 worked as specified in the zlib patch note and that -1 still raises the exception. Changing the test behaviour based on zlib.ZLIB_VERSION is likely the best option.

I'm not sure simply changing the value is the right thing to do - with older zlib versions (which do the wrong thing with 0), we definitely want that exception to be triggered.

For newer versions, we want to check that passing in 0 worked as specified in the zlib patch note and that -1 still raises the exception.

Changing the test behaviour based on zlib.ZLIB_VERSION is likely the best option.

History
Date	User	Action	Args
2010-03-30 09:10:32	ncoghlan	set	recipients: + ncoghlan, amaury.forgeotdarc, arekm, Arfrever, r.david.murray, valerio.turturici
2010-03-30 09:10:32	ncoghlan	set	messageid: <1269940232.05.0.059681088919.issue8193@psf.upfronthosting.co.za>
2010-03-30 09:10:30	ncoghlan	link	issue8193 messages
2010-03-30 09:10:30	ncoghlan	create