Message101761
You're right about the assert, I've just uploaded a new patch.
In non-blocking mode, ssl_socket.send(data) will return either 0 (which means nothing was sent, you'll have to try again), or len(data) when everything was sent. It can't return anything inbetween. This is because SSL_MODE_ENABLE_PARTIAL_WRITE is not enabled.
In my opinion, SSL_MODE_ENABLE_PARTIAL_WRITE should probably be enabled, although I don't know if it would have any consequence on existing code. Note that _ssl.c header has:
XXX should partial writes be enabled, SSL_MODE_ENABLE_PARTIAL_WRITE?
However, it's totally unrelated to our bug. Issue #8222 is also unrelated since SSL_MODE_AUTO_RETRY only applies to blocking sockets.
By the way, this bug was triaged "test needed". Am I missing anything? This is my first reported bug, I'm not sure about the process. |
|
Date |
User |
Action |
Args |
2010-03-26 18:05:03 | cbay | set | recipients:
+ cbay, vstinner, giampaolo.rodola |
2010-03-26 18:05:03 | cbay | set | messageid: <1269626703.51.0.537211356487.issue8240@psf.upfronthosting.co.za> |
2010-03-26 18:05:02 | cbay | link | issue8240 messages |
2010-03-26 18:05:01 | cbay | create | |
|