Message 101224 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	ncoghlan
Recipients	eric.smith, flox, ncoghlan
Date	2010-03-17.13:57:15
SpamBayes Score	1.879675e-06
Marked as misclassified	No
Message-id	<1268834238.89.0.642051449668.issue8155@psf.upfronthosting.co.za>
In-reply-to

Content
On a quick read through, the patch looks fine to me. I actually agree it would be nice if we could keep the "quiet=True" default (since it is a better match for the feature set we want in our own tests), but I see the compatibility issue as a deal breaker for that idea. It's probably worth adding a comment to that effect at the top of the function implementation to help people coming along later and asking "why did they choose the 'wrong' default value?".

On a quick read through, the patch looks fine to me.

I actually agree it would be nice if we could keep the "quiet=True" default (since it is a better match for the feature set we want in our own tests), but I see the compatibility issue as a deal breaker for that idea.

It's probably worth adding a comment to that effect at the top of the function implementation to help people coming along later and asking "why did they choose the 'wrong' default value?".

History
Date	User	Action	Args
2010-03-17 13:57:19	ncoghlan	set	recipients: + ncoghlan, eric.smith, flox
2010-03-17 13:57:18	ncoghlan	set	messageid: <1268834238.89.0.642051449668.issue8155@psf.upfronthosting.co.za>
2010-03-17 13:57:16	ncoghlan	link	issue8155 messages
2010-03-17 13:57:15	ncoghlan	create