This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author barry
Recipients barry, ezio.melotti, loewis, ned.deily, ronaldoussoren, tarek, vstinner
Date 2010-03-11.14:46:07
SpamBayes Score 1.0055828e-08
Marked as misclassified No
Message-id <1268318769.26.0.340745009342.issue8107@psf.upfronthosting.co.za>
In-reply-to
Content
Adding xxmodule.c to the test directory is more than I want to do for 2.6.5.  The actual crash happens because if sysconfig.get_config_var('srcdir') returns None, os.path.join() will traceback.  It doesn't know how to handle None arguments.  So my suggestion is that when srcdir is None, fallback to using sysconfig.project_base as before.

As long as that is guaranteed to be a string, we won't get the crash.  _get_source_filename() will return some bogus but syntactically valid path, and then the os.path.exists() test in test_suite() will return False, so the test will be skipped.  That seems like the safest change for 2.6.5 final, though I am fine with backporting the trunk fix for realzies in 2.6.6.
History
Date User Action Args
2010-03-11 14:46:09barrysetrecipients: + barry, loewis, ronaldoussoren, vstinner, tarek, ned.deily, ezio.melotti
2010-03-11 14:46:09barrysetmessageid: <1268318769.26.0.340745009342.issue8107@psf.upfronthosting.co.za>
2010-03-11 14:46:08barrylinkissue8107 messages
2010-03-11 14:46:07barrycreate