➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: wrong errno check
Type: behavior Stage:
Components: Tests Versions: Python 3.1, Python 3.2, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: pino, pitrou
Priority: normal Keywords: patch

Created on 2010-09-18 16:44 by pino, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
errno_py3k.diff pino, 2010-09-18 16:44 errno fix, branch py3k
Messages (2)
msg116813 - (view) Author: Pino Toscano (pino) Date: 2010-09-18 16:44 
In Lib/test/test_subprocess.py there's a check of an errno value done against a number, instead of using the proper E* constants, which is not portable (POSIX does not specify any actual value of the E* constants).
This makes the test test_leaking_fds_on_error fail on OSes where the errno ENOENT has a value different than two (like on GNU/Hurd, for example).

The attached patch was done in the py3k branch, but the issue appears in any other branch (including trunk). Could you please fix the issue also in the active Python branches?
msg116819 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2010-09-18 18:17 
Fixed in r84878 (3.2), r84879 (2.7) and r84880 (3.1). Thank you!
History
Date User Action Args
2022-04-11 14:57:06adminsetgithub: 54103
2010-09-18 18:17:17pitrousetstatus: open -> closed
versions: + Python 3.1, Python 2.7
nosy: + pitrou

messages: + msg116819

resolution: fixed
2010-09-18 16:44:30pinocreate