➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2010-08-17 18:50 by pitrou, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Messages (3) | |||
|---|---|---|---|
| msg114144 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2010-08-17 18:50 | |
longobject.h uses SIZEOF_SOCKET_T: #if SIZEOF_SOCKET_T <= SIZEOF_LONG #define PyLong_FromSocket_t(fd) PyLong_FromLong((SOCKET_T)(fd)) #define PyLong_AsSocket_t(fd) (SOCKET_T)PyLong_AsLong(fd) #else #define PyLong_FromSocket_t(fd) PyLong_FromLongLong(((SOCKET_T)(fd)); #define PyLong_AsSocket_t(fd) (SOCKET_T)PyLong_AsLongLong(fd) #endif but SIZEOF_SOCKET_T doesn't exist at that point since it is defined in Modules/socketmodule.h which isn't part of Include/Python.h. As a result, PyLong_FromSocket_t is always aliased to PyLong_FromLong, which is wrong under 64-bit Windows (a SOCKET is 64-bit there, while a long is 32-bit). |
|||
| msg114145 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2010-08-17 18:55 | |
This is witnessed in MSVC warning messages such as: 2>..\Modules\socketmodule.c(1611) : warning C4244: 'function' : conversion from 'SOCKET_T' to 'long', possible loss of data |
|||
| msg114147 - (view) | Author: Dave Malcolm (dmalcolm) |
Date: 2010-08-17 19:15 | |
Looks like a dup of issue 4835 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:05 | admin | set | github: 53838 |
| 2010-08-17 19:17:23 | dmalcolm | set | status: open -> closed resolution: duplicate superseder: SIZEOF_SOCKET_T not defined |
| 2010-08-17 19:15:59 | dmalcolm | set | nosy:
+ dmalcolm messages: + msg114147 |
| 2010-08-17 18:55:51 | pitrou | set | messages: + msg114145 |
| 2010-08-17 18:50:11 | pitrou | create | |