Created on 2010-08-17 16:29 by dmalcolm, last changed 2010-09-28 22:45 by r.david.murray. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| fix-sed-invocations-in-runtests.sh.patch | dmalcolm, 2010-08-17 16:29 | Patch against py3k branch | ||
| Messages (4) | |||
|---|---|---|---|
| msg114134 - (view) | Author: Dave Malcolm (dmalcolm)  |
Date: 2010-08-17 16:29 | |
runtests.sh -x fails to work with more than two tests; for example, running:
$ ./runtests.sh -x test_httplib test_http_cookies test_dl
erroneously runs test_dl
By default, "sed -e s" only substitutes the first match - the invocations within runtests.sh need to add the trailing "g" flag to substitute all matches.
From "info sed":
The `s' command can be followed by zero or more of the following
FLAGS:
`g'
Apply the replacement to _all_ matches to the REGEXP, not just the
first.
Am attaching a patch.
(Seen with sed-4.2.1 on Fedora 13)
|
|||
| msg114136 - (view) | Author: Dave Malcolm (dmalcolm) |
Date: 2010-08-17 16:31 | |
FWIW it works with two args, but adding the third fails; echoing PAT indicates the generated regex is missing the "|" separator: ^(test_httplib|test_http_cookies test_dl)$ |
|||
| msg117392 - (view) | Author: Sandro Tosi (sandro.tosi) * |
Date: 2010-09-25 21:23 | |
Hello, the patch applies cleanly against up-to-date py3k branch: is there anything else to do before committing it? Regards, Sandro |
|||
| msg117559 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2010-09-28 22:45 | |
Fixed in py3k r85078, 3.1 r85079. Note that the only fix required was to the 'PAT' line, the other sed expressions are operating only on single filenames-per-line and so don't need the 'g' added. I don't see runtests.sh in 2.7 (or 2.6), yet the history goes back quite a few years... |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2010-09-28 22:45:02 | r.david.murray | set | status: open -> closed nosy: + r.david.murray versions: - Python 3.3 messages: + msg117559 resolution: fixed type: behavior stage: patch review -> committed/rejected |
| 2010-09-25 21:23:10 | sandro.tosi | set | nosy:
+ sandro.tosi messages: + msg117392 |
| 2010-08-17 16:31:36 | dmalcolm | set | keywords:
patch, patch, easy, needs review messages: + msg114136 |
| 2010-08-17 16:29:35 | dmalcolm | create | |