This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: ssl has bad coding style
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.1, Python 3.2, Python 2.7, Python 2.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: djc, ezio.melotti, janssen, loewis
Priority: low Keywords:

Created on 2010-01-18 08:50 by djc, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (5)
msg97993 - (view) Author: Dirkjan Ochtman (djc) * (Python committer) Date: 2010-01-18 08:50
Sorry to be nitpicking here, but it kind of sticks out when you take your first look at ssl.py. While PEP 8 only talks about whitespace before the function call argument list parenthesis, I think this should also go for function definition. ssl has a lot of definitions like this:

    def send (self, data, flags=0):

(But not all of them.) Maybe that should be fixed up (I can do it myself, if that's alright), and maybe PEP 8 should be clarified as well?
msg97995 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2010-01-18 09:00
There should be no space between the name of the function and the '(' in both the cases. However the PEP 8 also says that "Consistency within one module or function is most important" and we usually avoid this kind of refactoring because they just make svn blame harder to use without having any real advantage.
msg97996 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2010-01-18 09:02
I think dropping the spaces after the function names is fine in this case; the module is inconsistent in this matter.
msg97998 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2010-01-18 09:17
Ok, done in r77595 (trunk), r77596 (release26-maint), r77597 (py3k) and r77598 (release31-maint).
msg98000 - (view) Author: Dirkjan Ochtman (djc) * (Python committer) Date: 2010-01-18 09:34
Thanks!
History
Date User Action Args
2022-04-11 14:56:56adminsetgithub: 51979
2010-01-18 09:34:12djcsetmessages: + msg98000
2010-01-18 09:17:18ezio.melottisetstatus: open -> closed
versions: + Python 2.6, Python 3.1, Python 3.2
messages: + msg97998

assignee: ezio.melotti
resolution: fixed
stage: resolved
2010-01-18 09:02:47loewissetstatus: pending -> open
nosy: + loewis
messages: + msg97996

2010-01-18 09:00:28ezio.melottisetstatus: open -> pending
priority: low

nosy: + ezio.melotti
messages: + msg97995
2010-01-18 08:50:22djcsettype: enhancement
2010-01-18 08:50:08djccreate