Created on 2009-01-14 18:04 by inducer, last changed 2011-06-05 03:38 by benjamin.peterson. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| python-2.7-const-error.1.patch | eckhardt, 2009-01-14 19:41 | patch | review | |
| Messages (7) | |||
|---|---|---|---|
| msg79868 - (view) | Author: Andreas Kloeckner (inducer) | Date: 2009-01-14 18:04 | |
The "name" argument to PyErr_NewException() should be changed from "char *" to "const char *". Since the rest of pyerrors.h is const-correct, this seems like an omission. |
|||
| msg79871 - (view) | Author: Ulrich Eckhardt (eckhardt) | Date: 2009-01-14 19:41 | |
It's not just that function, at least not in trunk. There are also PyErr_SetFromErrnoWithFilename, PyErr_SetFromErrnoWithUnicodeFilename and _PyErr_BadInternalCall which should be made const correct, see attached patch for trunk. This patch also fixes some inconsistencies between the documentation and warning support functions. |
|||
| msg112687 - (view) | Author: Terry J. Reedy (terry.reedy) *  |
Date: 2010-08-03 21:18 | |
Martin, do you agree with the premise of this issue? The patch consists of adding 'const' in about 6 places in code and corresponding 6 places in capi doc. |
|||
| msg118914 - (view) | Author: Andreas Kloeckner (inducer) | Date: 2010-10-17 03:48 | |
ping? |
|||
| msg118957 - (view) | Author: Martin v. Löwis (loewis) * |
Date: 2010-10-17 17:58 | |
Assuming the patch doesn't cause warnings on the compilers that we use, it looks fine to me. |
|||
| msg137678 - (view) | Author: Andreas Kloeckner (inducer) | Date: 2011-06-05 03:20 | |
ping? |
|||
| msg137680 - (view) | Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2011-06-05 03:38 | |
This patch is not applicable anymore to 3.x. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2011-06-05 03:38:30 | benjamin.peterson | set | status: open -> closed nosy: + benjamin.peterson messages: + msg137680 resolution: out of date |
| 2011-06-05 03:20:09 | inducer | set | messages: + msg137678 |
| 2010-10-17 17:58:05 | loewis | set | messages: + msg118957 |
| 2010-10-17 03:48:04 | inducer | set | messages: + msg118914 |
| 2010-08-03 21:18:34 | terry.reedy | set | versions:
+ Python 3.1, Python 3.2, - Python 2.6, Python 2.5, Python 3.0 nosy: + loewis, terry.reedy messages: + msg112687 keywords: + easy, - patch |
| 2009-06-22 13:58:54 | inducer | set | versions: + Python 2.7 |
| 2009-01-16 16:43:39 | sebastinas | set | nosy: + sebastinas |
| 2009-01-14 19:41:54 | eckhardt | set | files:
+ python-2.7-const-error.1.patch nosy: + eckhardt messages: + msg79871 keywords: + patch |
| 2009-01-14 18:04:58 | inducer | create | |