This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Send a patch to libexpat to solve _POSIX_C_SOURCE issue.
Type: enhancement Stage: resolved
Components: Build Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: corona10 Nosy List: christian.heimes, corona10, serhiy.storchaka, vstinner
Priority: normal Keywords: patch

Created on 2021-10-15 01:56 by corona10, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
0001-Reorder-the-location-of-including-expat_config.h.patch corona10, 2021-10-15 06:53
Messages (5)
msg403968 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2021-10-15 01:56
Yesterday, I left an issue to libexpat project about what we solved yesterday to follow Christian suggestion.

https://github.com/libexpat/libexpat/issues/513

The maintainer suggests sending a patch with reordering all headers files related to expat_config.h.
I am now preparing the patch.

I would like to know if there are more issues that we have to solve except header ordering that I don't know yet :)
msg403973 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2021-10-15 06:31
Related PRs

- https://github.com/python/cpython/commit/d413c503636cde2a6ab0ada25dccb0134633a8e6 by Dong-hee
- https://github.com/python/cpython/commit/8177404d520e81f16324a900f093adf3856d33f8 by Pablo
- https://github.com/python/cpython/commit/cf247359d5b7082044eea1fa94b5211a172b1ff6 by Victor
- https://github.com/python/cpython/commit/aa15276ee9554922919df1eb1a78826a102fb321 by Tiran
msg403975 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2021-10-15 06:53
I will send this patch file, when I apply this patch file, my compiler did not raise _POSIX_C_SOURCE issue.
(gcc version 8.4.1 20200928 (Red Hat 8.4.1-1) (GCC))

CPython affects
- xmltok.c
- xmlrole.c (Not yet applied to CPython code)

Not affected
- xmlfile.c
msg403976 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2021-10-15 06:53
Please take a look at the patch file that it will be okay to CPython code base :)
msg404140 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2021-10-17 15:41
https://github.com/libexpat/libexpat/pull/514

merged, The change is affected to libexpat 2.4.2
History
Date User Action Args
2022-04-11 14:59:51adminsetgithub: 89641
2021-10-18 08:36:15corona10setstatus: open -> closed
resolution: fixed
stage: resolved
2021-10-17 15:41:33corona10setmessages: + msg404140
2021-10-15 06:53:47corona10setmessages: + msg403976
2021-10-15 06:53:15corona10setfiles: + 0001-Reorder-the-location-of-including-expat_config.h.patch
keywords: + patch
messages: + msg403975
2021-10-15 06:31:08corona10setmessages: + msg403973
2021-10-15 01:56:59corona10create