Issue 44205: shutil.copystat can fail when copying to a file system with a smaller limit

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/88371

classification

Title:	shutil.copystat can fail when copying to a file system with a smaller limit
Type:	crash	Stage:	patch review
Components:	Library (Lib)	Versions:	Python 3.11, Python 3.10, Python 3.9, Python 3.8, Python 3.7, Python 3.6

process

Status:	open	Resolution:
Dependencies:		Superseder:
Assigned To:		Nosy List:	chrisburr, wiso, zlmarshall
Priority:	normal	Keywords:	patch

Created on 2021-05-21 15:10 by chrisburr, last changed 2022-04-11 14:59 by admin.

Pull Requests
URL	Status	Linked	Edit
PR 26282	open	chrisburr, 2021-05-21 15:12

Messages (1)
msg394118 - (view)	Author: Chris Burr (chrisburr) *	Date: 2021-05-21 15:10
When copying files between systems with different limits on the size of the extended attributes that can be added to a file shutil.copystat can fail with: /cvmfs/lhcb.cern.ch/lib/var/lib/LbEnv/2064/stable/linux-64/lib/python3.8/shutil.py in copystat(src, dst, follow_symlinks) 377 # We must copy extended attributes before the file is (potentially) 378 # chmod()'ed read-only, otherwise setxattr() will error with -EACCES. --> 379 _copyxattr(src, dst, follow_symlinks=follow) 380 try: 381 lookup("chmod")(dst, mode, follow_symlinks=follow) /cvmfs/lhcb.cern.ch/lib/var/lib/LbEnv/2064/stable/linux-64/lib/python3.8/shutil.py in _copyxattr(src, dst, follow_symlinks) 327 try: 328 value = os.getxattr(src, name, follow_symlinks=follow_symlinks) --> 329 os.setxattr(dst, name, value, follow_symlinks=follow_symlinks) 330 except OSError as e: 331 if e.errno not in (errno.EPERM, errno.ENOTSUP, errno.ENODATA, OSError: [Errno 28] No space left on device: '/tmp/lhcb' This is caused by the destination filesystem having a smaller limit on the size of the extended attributes. I think this behaviour is unexpected as other failures are silently ignored (e.g. the destination doesn't support extended attributes).

msg394118 - (view)

Author: Chris Burr (chrisburr) *

Date: 2021-05-21 15:10

When copying files between systems with different limits on the size of the extended attributes that can be added to a file shutil.copystat can fail with:

/cvmfs/lhcb.cern.ch/lib/var/lib/LbEnv/2064/stable/linux-64/lib/python3.8/shutil.py in copystat(src, dst, follow_symlinks)
    377     # We must copy extended attributes before the file is (potentially)
    378     # chmod()'ed read-only, otherwise setxattr() will error with -EACCES.
--> 379     _copyxattr(src, dst, follow_symlinks=follow)
    380     try:
    381         lookup("chmod")(dst, mode, follow_symlinks=follow)

/cvmfs/lhcb.cern.ch/lib/var/lib/LbEnv/2064/stable/linux-64/lib/python3.8/shutil.py in _copyxattr(src, dst, follow_symlinks)
    327             try:
    328                 value = os.getxattr(src, name, follow_symlinks=follow_symlinks)
--> 329                 os.setxattr(dst, name, value, follow_symlinks=follow_symlinks)
    330             except OSError as e:
    331                 if e.errno not in (errno.EPERM, errno.ENOTSUP, errno.ENODATA,

OSError: [Errno 28] No space left on device: '/tmp/lhcb'

This is caused by the destination filesystem having a smaller limit on the size of the extended attributes. I think this behaviour is unexpected as other failures are silently ignored (e.g. the destination doesn't support extended attributes).

History
Date	User	Action	Args
2022-04-11 14:59:45	admin	set	github: 88371
2021-07-07 10:06:03	wiso	set	nosy: + wiso
2021-07-07 10:00:20	zlmarshall	set	nosy: + zlmarshall
2021-05-21 15:12:22	chrisburr	set	keywords: + patch stage: patch review pull_requests: + pull_request24888
2021-05-21 15:10:36	chrisburr	create