classification
Title: New function in Tkinter.py: setup_master
Type: enhancement Stage: commit review
Components: Tkinter Versions: Python 3.2
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: gpolo Nosy List: gpolo
Priority: normal Keywords: needs review, patch

Created on 2008-11-18 12:39 by gpolo, last changed 2010-11-28 05:26 by eric.araujo.

Files
File name Uploaded Description Edit
applying_setup_master.diff gpolo, 2008-11-18 12:39
setup_master.diff gpolo, 2008-11-18 12:45
Messages (2)
msg76005 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2008-11-18 12:39
Hi,

I've added a new function called setup_master. 

This function is responsible for returning an usable master to the
caller, or fail and say so. The function is useful for any wrapper
basically, since all them has to set up a master sometime (or maybe
always require a master, but that is not very nice) and will usually do
it half wrong. The half wrong is about relying on _default_root being
available in Tkinter, which is not the case if support for default root
has been disabled.

There are two patches, the first adds the function, the second applies
it self where necessary in Tkinter. The later also adds some new
behaviour in Tkinter, previously Variable class and subclasses wouldn't
work properly without prior creation of a master (there are similar
problems in other parts too).
msg80988 - (view) Author: Guilherme Polo (gpolo) * (Python committer) Date: 2009-02-02 20:09
Any chance I can get this in ? I'm using something very similar to test
the ttk wrapper and will also be using in other tests, extensions would
also benefit from it, and old code doesn't get affected to it.
History
Date User Action Args
2010-11-28 05:26:26eric.araujosetkeywords: + needs review
assignee: gpolo
stage: commit review
type: enhancement
versions: + Python 3.2, - Python 3.1, Python 2.7
2009-02-02 20:10:00gpolosetmessages: + msg80988
versions: + Python 3.1, - Python 3.0
2008-11-18 12:45:59gpolosetfiles: + setup_master.diff
2008-11-18 12:45:47gpolosetfiles: - setup_master.diff
2008-11-18 12:39:36gpolosetfiles: + applying_setup_master.diff
2008-11-18 12:39:18gpolocreate