This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: venv activate scripts do not pass ShellCheck
Type: enhancement Stage:
Components: Extension Modules Versions: Python 3.10
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: terry.reedy, user93448, vinay.sajip
Priority: normal Keywords:

Created on 2020-08-10 15:52 by user93448, last changed 2022-04-11 14:59 by admin.

Messages (2)
msg375125 - (view) Author: D. A. Pellegrino (user93448) Date: 2020-08-10 15:52
The activate scripts created by the venv module do not pass checks by ShellCheck (https://www.shellcheck.net/). ShellCheck generally has a point for each warning and note generated against the venv activate scripts. Addressing the ShellCheck reports would align the activate script implementation with best practices.
msg375430 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2020-08-14 20:09
(3.6 only gets security fixes.)  Please be more specific: venv produces 6 types of scripts.  Which type(s) are seen as buggy?  Can you paste a script produced by venv and its ShellCheck output?  (The web site has a paste-in box.)  Have you used ShellCheck?  Can you sign the contributor agreement submit a PR?  (Yes, we do sometimes create, review, and upon agreement merge patches based of various code and text checkers.)
History
Date User Action Args
2022-04-11 14:59:34adminsetgithub: 85688
2020-08-14 20:09:18terry.reedysetnosy: + terry.reedy, vinay.sajip

messages: + msg375430
versions: + Python 3.10, - Python 3.6
2020-08-10 15:52:50user93448create