This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: fix for an AIX optimizer weirdness in getargs.c
Type: Stage:
Components: None Versions:
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: gvanrossum Nosy List: gvanrossum, marangoz
Priority: normal Keywords: patch

Created on 2000-06-27 23:39 by marangoz, last changed 2022-04-10 16:02 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
None marangoz, 2000-06-27 23:39 None
Messages (4)
msg32899 - (view) Author: Vladimir Marangozov (marangoz) * (Python triager) Date: 2000-06-27 23:39
 
msg32900 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2000-06-28 14:16
Vladimir, can you comment on this?
msg32901 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2000-06-28 14:16
Never mind! :-)
msg32902 - (view) Author: Vladimir Marangozov (marangoz) * (Python triager) Date: 2000-06-27 23:46
Moved here from patches@python.org

This patch fixes a problem on AIX with the signed int case code in getargs.c, after Trent Mick's intervention about MIN/MAX overflow checks.  The AIX compiler/optimizer generates bogus code with the default flags "-g -O" causing test_builtin to fail: int("10", 16) <> 16L.  Hopefully, swapping the two checks in the signed int code makes the problem go away.

Also, make the error messages fit in 80 char lines in the source.


[Trent Mick]:
>
> Does it?

[me]
Yes, it does. Without optimization, everything was okay, with -O it crashed. This is the second time that swapping statemets in the code alleviates bugs in some (old) AIX optimizers ... [snip] So, as far as
such patches don't hurt the semantics of the code, they are fine.

[Trent]
> Seconded. +1
History
Date User Action Args
2022-04-10 16:02:01adminsetgithub: 32472
2000-06-27 23:39:27marangozcreate