This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: LockTests in test_imp should be skipped when thread is not available
Type: Stage:
Components: Tests Versions: Python 3.0, Python 2.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, ocean-city
Priority: normal Keywords: patch

Created on 2008-09-08 22:35 by ocean-city, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_imp.patch ocean-city, 2008-09-08 22:35
test_imp.patch ocean-city, 2008-09-08 22:54 v2
Messages (5)
msg72801 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2008-09-08 22:35
LockTests is meaningfull only when thread is available, so this patch
removes it from tests when thread is unavailable. This patch is for trunk.
msg72802 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-09-08 22:38
Why not just append LockTests to the tests after instead of deleting it
from the list?
msg72803 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2008-09-08 22:54
Like attached new patch? There was no strong meaning. :-)
del tests[0] can can preserve order of tests, but it's not so important,
is it.
msg72804 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-09-08 22:55
Looks good to me.
msg72827 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2008-09-09 07:34
Thanks. Fixed in r66319(trunk) and r66334(py3k).
History
Date User Action Args
2022-04-11 14:56:38adminsetgithub: 48056
2008-09-09 07:34:21ocean-citysetstatus: open -> closed
resolution: fixed
2008-09-09 07:34:05ocean-citysetmessages: + msg72827
2008-09-08 22:55:42benjamin.petersonsetmessages: + msg72804
2008-09-08 22:54:33ocean-citysetfiles: + test_imp.patch
messages: + msg72803
2008-09-08 22:38:00benjamin.petersonsetnosy: + benjamin.peterson
messages: + msg72802
2008-09-08 22:35:53ocean-citycreate