Created on 2008-08-27 12:53 by pitrou, last changed 2010-11-04 20:50 by pitrou. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue3699-py3k.patch | sandro.tosi, 2010-11-03 23:55 | |||
| issue3699-py3k-v2.patch | sandro.tosi, 2010-11-04 18:39 | |||
| Messages (6) | |||
|---|---|---|---|
| msg72025 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2008-08-27 12:53 | |
./python3 Lib/test/regrtest.py -v -M 2.1Gb test_bigaddrspace test_bigaddrspace test_concat (test.test_bigaddrspace.StrTest) ... ERROR test_optimized_concat (test.test_bigaddrspace.StrTest) ... ERROR ====================================================================== ERROR: test_concat (test.test_bigaddrspace.StrTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/antoine/py3k/__svn__/Lib/test/support.py", line 697, in wrapper return f(self) File "/home/antoine/py3k/__svn__/Lib/test/test_bigaddrspace.py", line 13, in test_concat s1 = 'x' * MAX_Py_ssize_t OverflowError: repeated string is too long ====================================================================== ERROR: test_optimized_concat (test.test_bigaddrspace.StrTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/antoine/py3k/__svn__/Lib/test/support.py", line 697, in wrapper return f(self) File "/home/antoine/py3k/__svn__/Lib/test/test_bigaddrspace.py", line 18, in test_optimized_concat x = 'x' * MAX_Py_ssize_t OverflowError: repeated string is too long ---------------------------------------------------------------------- Ran 2 tests in 0.019s |
|||
| msg112129 - (view) | Author: Mark Lawrence (BreamoreBoy) | Date: 2010-07-31 11:01 | |
Adding 2.7 as blame shows the file is essentially the same as for py3k. Can the priority of this be lowered to normal? |
|||
| msg112130 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2010-07-31 11:12 | |
No, the problem is specific to 3.x, because the tests haven't been ported properly. I still want to have the priority as "high", because a broken test should not be left as-is. |
|||
| msg120359 - (view) | Author: Sandro Tosi (sandro.tosi) * |
Date: 2010-11-03 23:55 | |
After quite a bit of discussion with Antoine on IRC, here it is a preliminary patch: it uses byte instead of string, but at least it works :) I'll work on a string (additional) test class hopefully tomorrow |
|||
| msg120427 - (view) | Author: Sandro Tosi (sandro.tosi) * |
Date: 2010-11-04 18:39 | |
The attached patch implements the same tests of byte for string objects. |
|||
| msg120437 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2010-11-04 20:50 | |
I've made cosmetic changes and applied in r86175 (3.2) and r86176 (3.1). Thank you! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2010-11-04 20:50:39 | pitrou | set | status: open -> closed priority: high -> normal messages: + msg120437 resolution: fixed stage: patch review -> committed/rejected |
| 2010-11-04 18:39:23 | sandro.tosi | set | files:
+ issue3699-py3k-v2.patch assignee: sandro.tosi messages: + msg120427 stage: patch review |
| 2010-11-03 23:55:01 | sandro.tosi | set | files:
+ issue3699-py3k.patch nosy: + sandro.tosi messages: + msg120359 keywords: + patch |
| 2010-07-31 11:12:56 | pitrou | set | messages:
+ msg112130 versions: - Python 2.7 |
| 2010-07-31 11:01:32 | BreamoreBoy | set | nosy:
+ BreamoreBoy messages: + msg112129 versions: + Python 2.7 |
| 2010-05-11 20:48:53 | terry.reedy | set | versions: + Python 3.2, - Python 3.0 |
| 2009-03-14 01:12:53 | pitrou | set | versions: + Python 3.1 |
| 2008-08-27 12:53:22 | pitrou | create | |