This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test issues on 64bit windows
Type: Stage:
Components: Tests, Windows Versions: Python 2.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: mhammond Nosy List: mhammond, pitrou
Priority: normal Keywords: 64bit, patch

Created on 2008-08-21 03:22 by mhammond, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
win64_test_failures.patch mhammond, 2008-08-21 03:22 patch to skip certain tests on win64
win64_test_failures.patch mhammond, 2008-08-21 23:40 better patch that just uses sys.maxsize
Messages (5)
msg71603 - (view) Author: Mark Hammond (mhammond) * (Python committer) Date: 2008-08-21 03:22
A number of tests are designed to be skipped on 64bits, but they don't
detect 64bit windows builds as 64bits.  Also, test_bytes.test_repeat()
assumes sys.maxint bytes can't be allocated, which isn't necessarily
true on Win64.

I'm attaching a patch that arranges to skip these tests.
msg71638 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2008-08-21 13:29
Mark, that check looks fragile:

+IS32BIT = sys.maxint == 0x7fffffff and "64 bit" not in sys.version

Why don't you check for sys.maxsize instead? By construction,
sys.maxsize should give you the pointer width (minus the sign bit ;-)).
msg71701 - (view) Author: Mark Hammond (mhammond) * (Python committer) Date: 2008-08-21 23:40
I forgot about sys.maxsize - that makes things much cleaner, and even
means I don't need to skip the check for insane amounts of memory.

If you think this is OK, please also specifically say if you approve for
me to check it into trunk for 2.6.  Thanks.
msg71734 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2008-08-22 09:32
Mark, your patch is ok to me. You can check it in.
msg71796 - (view) Author: Mark Hammond (mhammond) * (Python committer) Date: 2008-08-23 01:00
Thanks.  Checked into the trunk in r65986
History
Date User Action Args
2022-04-11 14:56:37adminsetgithub: 47875
2008-08-23 01:00:17mhammondsetstatus: open -> closed
keywords: patch, patch, 64bit
resolution: fixed
messages: + msg71796
2008-08-22 09:32:05pitrousetkeywords: patch, patch, 64bit
messages: + msg71734
2008-08-21 23:40:03mhammondsetkeywords: patch, patch, 64bit
files: + win64_test_failures.patch
messages: + msg71701
2008-08-21 13:29:18pitrousetkeywords: patch, patch, 64bit
nosy: + pitrou
messages: + msg71638
2008-08-21 03:22:15mhammondcreate