This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: PEPping distutils/core.py
Type: enhancement Stage: resolved
Components: Distutils Versions: Python 3.8
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, dangerwillrobinsondanger, dstufft, eric.araujo, xtreak
Priority: normal Keywords:

Created on 2018-09-15 14:01 by dangerwillrobinsondanger, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 9329 dangerwillrobinsondanger, 2018-09-15 14:01
Messages (4)
msg325433 - (view) Author: John Joyce (dangerwillrobinsondanger) * Date: 2018-09-15 14:01
In distutils/core.py ...

Line 227 is over-indented, inconsistent with the rest of the file.
Line 226 is over-indented, inconsistent with the rest of the file.

Line 114 is over-indented by 2 characters, inconsistent with the rest of the file.
        else:
            raise SystemExit("error in %s setup command: %s" % \
                  (attrs['name'], msg))


Line 113 backslash should not be needed to continue the line between brackets.

Line 102 there is an extra space before the "not" keyword.
    if 'script_args'  not in attrs:


Line 57 could use 1 more blank line above it.

Line 33 'script' is assigned but not used.

Line 32 could use 1 more blank line above it.


run_setup and setup had space before (
msg325436 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python committer) Date: 2018-09-15 15:06
Thanks for the contribution. Is there any syntax error on using the file since you have classified it as compile error or the error messages are related to linters? On a general note style related contributions are not merged since they create whitespace noise while traversing git history. I will let it for the reviewers though to decide on this.

Thanks
msg325439 - (view) Author: John Joyce (dangerwillrobinsondanger) * Date: 2018-09-15 15:40
Oh, I see. I did not realize that tidying would not be accepted. That explains a lot. As it offended linters based on PEPs I chose that as the best match. It is pedantic, but many linting actions are not far from compiling... they are generally parsing to determine PEP compliance.
msg325447 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2018-09-15 16:50
Thanks for the report and for the PR, John. Karthikeyan is correct.

Many of the modules in the stdlib predate PEP 8. Also, making PEP 8-only changes would make "git blame" less useful and can cause regressions (IIRC it has happened at least once, but I don't remember the details at the moment.)

Closing this as 'rejected'. I hope you will continue contributing to Python!
History
Date User Action Args
2022-04-11 14:59:05adminsetgithub: 78874
2018-09-15 16:50:34berker.peksagsetstatus: open -> closed

type: compile error -> enhancement

nosy: + berker.peksag
messages: + msg325447
resolution: rejected
stage: resolved
2018-09-15 15:40:49dangerwillrobinsondangersetmessages: + msg325439
2018-09-15 15:06:05xtreaksetnosy: + xtreak
messages: + msg325436
2018-09-15 14:01:11dangerwillrobinsondangercreate