This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: data parameter for binascii.b2a_base64 is not positional-only
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: martin.panter, serhiy.storchaka, vstinner, xiang.zhang
Priority: normal Keywords:

Created on 2017-04-29 09:22 by xiang.zhang, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 1352 merged xiang.zhang, 2017-04-29 09:43
Messages (3)
msg292585 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2017-04-29 09:22
Before functions in binascii having *data* parameter all accept it as positionaly-only. But after #25357, binascii.b2a_base64 changed it to accept keyword argument also but it looks unintentional.
msg292589 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-04-29 09:36
Because this change looks unintentional (no one of reviewers even noticed it) and was not documented, I think it is better to make the data parameter positional-only in 3.7. The chance of breaking a user code is very low, and even if this breaks some code, it is easy to fix it. But it is safer to left 3.6 untouched.
msg292603 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-04-29 22:24
Right, my API change was unintentional.
History
Date User Action Args
2022-04-11 14:58:45adminsetgithub: 74392
2017-05-01 05:12:47xiang.zhangsetstatus: open -> closed
stage: resolved
resolution: fixed
versions: - Python 3.6
2017-04-29 22:24:20vstinnersetmessages: + msg292603
2017-04-29 09:43:50xiang.zhangsetpull_requests: + pull_request1464
2017-04-29 09:36:09serhiy.storchakasetmessages: + msg292589
2017-04-29 09:22:01xiang.zhangcreate