This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: removal of stale code from myreadline.c
Type: Stage:
Components: Interpreter Core Versions: Python 3.0, Python 3.1, Python 3.2, Python 2.7, Python 2.6
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: akuchling Nosy List: JosephArmbruster, akuchling, jesstess, stutzbach
Priority: normal Keywords: patch

Created on 2008-04-06 02:00 by JosephArmbruster, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
myreadline.patch JosephArmbruster, 2008-04-06 02:00
myreadline-v2.patch jesstess, 2009-08-22 23:58 patch with 8 space tabs, against trunk
Messages (4)
msg65015 - (view) Author: Joseph Armbruster (JosephArmbruster) Date: 2008-04-06 02:00
This patch removes a stale for loop from myreadline.c:

http://svn.python.org/projects/python/trunk @ 62180
msg84448 - (view) Author: Daniel Stutzbach (stutzbach) (Python committer) Date: 2009-03-30 01:07
This patch looks good to me and applies cleanly to the trunk.  Here's a
synopsis of the code (before the patch) in question:

static int
my_fgets(char *buf, int len, FILE *fp)
{
    for(;;) {
          /* a bunch of code that does not contain break or continue */
          return -2;
    }
}

The patch removes the extraneous for loop and un-indents the inside of
the loop.  However, the patch changes that section of code to use
4-space indents while the rest of the file uses 8-space indents.
msg91882 - (view) Author: Jessica McKellar (jesstess) * (Python triager) Date: 2009-08-22 23:58
Here's an updated patch against trunk that has 8 space tabs and doesn't
remove some of the existing comments like the other patch did. I checked
that the patch applies and that re-building doesn't error.
msg99861 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2010-02-22 22:49
Committed Jessica's patch to 2.7 trunk in rev78343.  Thanks to both Joseph and Jessica for their work!
History
Date User Action Args
2022-04-11 14:56:33adminsetgithub: 46812
2010-02-22 22:49:37akuchlingsetstatus: open -> closed

nosy: + akuchling
messages: + msg99861

assignee: akuchling
resolution: accepted
2009-08-22 23:58:26jesstesssetfiles: + myreadline-v2.patch
versions: + Python 3.2
nosy: + jesstess

messages: + msg91882
2009-03-30 01:07:22stutzbachsetnosy: + stutzbach

messages: + msg84448
versions: + Python 3.0, Python 3.1, Python 2.7
2008-04-06 02:00:24JosephArmbrustercreate