This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test__supports_universal_builds failure on Python 3.5.0a0 osx 10.6
Type: Stage: resolved
Components: macOS Versions:
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: Nosy List: Alex.LordThorsen, ned.deily, ronaldoussoren
Priority: normal Keywords: patch

Created on 2015-04-13 21:19 by Alex.LordThorsen, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test__supports_universal_builds.patch Alex.LordThorsen, 2015-04-13 21:19
Messages (2)
msg240758 - (view) Author: Alex LordThorsen (Alex.LordThorsen) * Date: 2015-04-13 21:19
On a fresh clone of cpython 3.5.0a0 if you run

$ ./configure --with-pydebug && make -j2
$ ./python.exe -m test.test__osx_support -j3

on osx 10.10.2 (14C109) these two test failures are reported.


    ======================================================================
    FAIL: test__supports_universal_builds (__main__.Test_OSXSupport)
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/Users/alexlord/mercurial/cpython/Lib/test/test__osx_support.py", line 113, in test__supports_universal_builds
        _osx_support._supports_universal_builds())
    AssertionError: False != True

This turned out to be a problem with the line 12 in test_osx_support.py

        self.assertEqual(platform.mac_ver()[0].split('.') >= ['10', '4'],$
                             _osx_support._supports_universal_builds())$

Specifically the section

    platform.mac_ver()[0].split('.') >= ['10', '4']

Which reduced to

    ['10', '10', '2'] >= ['10', '4] which evaluated to False.

To fix this I imported distutils.version.StrictVersion and added these three lines.

+        mac_version = StrictVersion(platform.mac_ver()[0])
+        test_if_greater_version = StrictVersion('10.4')
+        self.assertEqual(mac_version >= test_if_greater_version,
msg240768 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2015-04-13 21:39
This also appears to be due to not building with an up-to-date version of the source (see msg240759 in Issue23939).
History
Date User Action Args
2022-04-11 14:58:15adminsetgithub: 68128
2015-04-13 22:16:13ned.deilysetstatus: pending -> closed
2015-04-13 21:39:30ned.deilysetstatus: open -> pending
resolution: out of date
messages: + msg240768

stage: resolved
2015-04-13 21:19:35Alex.LordThorsensetnosy: + ronaldoussoren, ned.deily
components: + macOS
2015-04-13 21:19:25Alex.LordThorsencreate