This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: 'TestTCPServer' is not defined
Type: crash Stage: needs patch
Components: Tests Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: vinay.sajip Nosy List: larry, vinay.sajip
Priority: high Keywords: buildbot

Created on 2013-09-27 18:50 by larry, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (3)
msg198498 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2013-09-27 18:50
The Win32 buildbots just started failing:

http://buildbot.python.org/all/waterfall?category=3.x.stable

They fail with this traceback:

test test_logging crashed -- Traceback (most recent call last):
  File "../lib/test/regrtest.py", line 1269, in runtest_inner
    the_module = importlib.import_module(abstest)
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\lib\importlib\__init__.py", line 95, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1613, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1594, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1561, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 607, in _check_name_wrapper
  File "<frozen importlib._bootstrap>", line 1056, in load_module
  File "<frozen importlib._bootstrap>", line 926, in load_module
  File "<frozen importlib._bootstrap>", line 274, in _call_with_frames_removed
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\lib\test\test_logging.py", line 1365, in <module>
    class SocketHandlerTest(BaseTest):
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\lib\test\test_logging.py", line 1369, in SocketHandlerTest
    server_class = TestTCPServer
NameError: name 'TestTCPServer' is not defined

I took a quick look at it and the code seemed fine... but obviously there's something going on.

Can you try to fix this before I cut 3.4a3 tomorrow?
msg198503 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2013-09-27 21:10
It's to do whether threading is available or not (not Windows related, AFAICT) ... I have corrected the code and it now seems to be OK - the few buildbots that are red seem to be failing on other things.

I'll leave it to you to verify this and close this issue, but will try to keep an eye out for any further information on this.
msg198798 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2013-10-01 18:22
From the fact that 3.4a3 is out I assume it's OK to close this issue. The buildbots are no longer showing this error.
History
Date User Action Args
2022-04-11 14:57:51adminsetgithub: 63308
2013-10-01 18:22:41vinay.sajipsetstatus: open -> closed
resolution: fixed
messages: + msg198798
2013-09-27 21:10:41vinay.sajipsetmessages: + msg198503
2013-09-27 18:50:24larrycreate