OpenSSL fails compiling on the XP-4 buildbot. Judging by the errors below (snipped), the nasm version may be too old (?) to understand some of the assembler instructions used in the source. David, could you perhaps take a look?

http://buildbot.python.org/all/buildslaves/bolen-windows


Build:
  cd "d:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\PCbuild\"
  "d:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\PCbuild\python_d.exe" build_ssl.py Release Win32 -a
  
  Found a working perl at 'c:\Perl\bin\perl.exe'
  Executing ssl makefiles: nmake /nologo -f "ms\nt.mak"
  Building OpenSSL
  	nasm -f win32 -o tmp32\sha1-586.obj tmp32\sha1-586.asm
  tmp32\sha1-586.asm:2646: warning: label alone on a line without a colon might be in error
  tmp32\sha1-586.asm:2647: error: parser: instruction expected
  tmp32\sha1-586.asm:2648: error: symbol `vmovdqa' redefined
  tmp32\sha1-586.asm:2648: error: parser: instruction expected
  tmp32\sha1-586.asm:2649: error: symbol `vmovdqa' redefined
  tmp32\sha1-586.asm:2649: error: parser: instruction expected
  tmp32\sha1-586.asm:2650: error: symbol `vmovdqa' redefined
  tmp32\sha1-586.asm:2650: error: parser: instruction expected
  tmp32\sha1-586.asm:2651: error: symbol `vmovdqa' redefined
  tmp32\sha1-586.asm:2651: error: parser: instruction expected
  tmp32\sha1-586.asm:2658: error: symbol `vmovdqa' redefined
  tmp32\sha1-586.asm:2658: error: parser: instruction expected
  tmp32\sha1-586.asm:2659: error: symbol `vmovdqa' redefined
  tmp32\sha1-586.asm:2659: error: parser: instruction expected
  tmp32\sha1-586.asm:2660: error: symbol `vmovdqa' redefined
  tmp32\sha1-586.asm:2660: error: parser: instruction expected
  tmp32\sha1-586.asm:2662: error: symbol `vmovdqa' redefined

Yeah, the XP buildbot was pretty old, at nasm 2.02, so I updated to the same 2.09 as the Win7 buildbot, restarted the last build and it went through compilation fine.

However, then it failed in test_ssl, and in checking, it looks like my Win7 buildbot is failing the same way.  I thought it might just be an independent problem, but then found issue 15172 from last June (like Jeremy I have 2.09.02) which seems to say OpenSSL 1.0.1+ needs nasm 2.10.  In Jeremy's case it only affected his 64-bit build, so maybe that's why I haven't seen it yet, but perhaps with the recent move to 1.0.1d it can affect 32-bit as well?

Ah, or wait, there's also issue 17425 that seems to indicate 1.0.1d may be at fault for that test failure.

Anyway, I installed the latest nasm 2.10.07 both both XP and Win7, and flushed the openssl tree in the 3.3 and 3.x build branches.  In retrying the XP 3.x build it still fails test_ssl, so I don't think there's anything else I can change on the buildbot side as it looks like fixing that needs us to switch to 1.0.1e

Yes, the test_ssl failure is orthogonal. Thanks for fixing the compile issue!