classification
Title: struni: for for poll, pep263, bigmem and a bit pickletool
Type: Stage:
Components: Tests Versions: Python 3.0
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: gvanrossum Nosy List: christian.heimes, gvanrossum (2)
Priority: normal Keywords patch

Created on 2007-07-11 20:02 by christian.heimes, last changed 2008-01-06 22:29 by admin.

Files
File name Uploaded Description Edit Remove
pep263_poll_bigmem_pickletools.diff christian.heimes, 2007-07-11 20:02 py3k-struni r56283
Messages (2)
msg52849 - (view) Author: Christian Heimes (christian.heimes) Date: 2007-07-11 20:02 
The patch fixes three unit test modules and some unit tests of pickletools.
msg52850 - (view) Author: Guido van Rossum (gvanrossum) Date: 2007-07-12 08:15 
I disagree with the pickletools fix; something should be changed not to return 8-bit strings.

Your fix for test_pep263.py was not included due to the file being marked as binary.  But it was already committed previously by Thomas Heller so no need to follow up.

The poll fix was already applied.

I tweaked the bigmem fix slightly and submitted it: Committed revision 56295.
History
Date User Action Args
2008-01-06 22:29:45adminsetkeywords: - py3k
versions: + Python 3.0
2007-07-11 20:02:08christian.heimescreate