classification
Title: make install change: Allow $DESTDIR to be relative
Type: enhancement Stage: test needed
Components: Build Versions: Python 3.2
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: dgreiman, hanwen, whit537
Priority: normal Keywords: patch

Created on 2006-07-11 23:56 by dgreiman, last changed 2010-08-09 03:34 by terry.reedy.

Files
File name Uploaded Description Edit
relative_destdir_fix.diff dgreiman, 2006-07-11 23:56 Patch to Makefile.pre.in (r50594)
Messages (4)
msg50662 - (view) Author: Douglas Greiman (dgreiman) Date: 2006-07-11 23:56
This patch allows the $DESTDIR variable used in 'make
install' to be a relative path.  It also avoids
constructing filenames starting with double slashes
('//') when DESTDIR is an absolute path.

Tested on RedHat 9.0 Linux on x86.
msg50663 - (view) Author: Chad Whitacre (whit537) Date: 2006-07-31 21:13
Logged In: YES 
user_id=340931

I'd also like to see the argument to 'configure --prefix='
also be relative. Could this patch be expanded in that
direction?
msg50664 - (view) Author: Douglas Greiman (dgreiman) Date: 2006-07-31 23:03
Logged In: YES 
user_id=1553997

That seems reasonable, however I believe it should be a
separate change since codewise the two changes are unrelated.
msg50665 - (view) Author: Han-Wen Nienhuys (hanwen) * Date: 2006-12-05 23:45
Agreed. I have never seen $DESTDIR prefixed with / in makefiles, so this patch should go in.

I don't see the point of making --prefix relative. 
you can do 

 --prefix=`cd ../relative ; pwd` 

if you need relative.

Putting relative paths in makefiles is asking for trouble, as the Makefile will call other makefiles in subdirectories, which would need to pass extra ../ overrides of prefix.
 
History
Date User Action Args
2010-08-09 03:34:55terry.reedysetversions: + Python 3.2, - Python 3.1, Python 2.7
2009-03-30 05:05:49ajaksu2setstage: test needed
type: enhancement
versions: + Python 3.1, Python 2.7, - Python 2.5
2006-07-11 23:56:10dgreimancreate