classification
Title: patch fixing #1448060 (gettext.py bug)
Type: behavior Stage: patch review
Components: Library (Lib) Versions: Python 3.1, Python 2.6
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: loewis Nosy List: loewis, syt (2)
Priority: high Keywords patch

Created on 2006-04-24 13:09 by syt, last changed 2009-03-21 02:21 by ajaksu2.

Files
File name Uploaded Description Edit Remove
gettext.py.patch syt, 2006-04-24 13:11
plurals.diff loewis, 2006-07-17 07:45
Messages (3)
msg50103 - (view) Author: Thenault Sylvain (syt) Date: 2006-04-24 13:09
Here is a patch for the bug described in
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1448060&group_id=5470

It follows the latest Martin followup as I understand
it. I'm not sure if multi-lines field handling should
be totally discarded while reading metadata headers (as
implemented), or if it should only be discarded for the
content-type and plural-forms header. If one think this
patch isn't correct, please comment so I can fix it.

Notice that if the second solution was intended, lines
such as 

"#-#-#-#-#  fr.po  #-#-#-#-#\n"

inserted by msgcat/msgmerge will have to be treated
differently (i.e. multi-lines support but skip lines
begining with a #).
msg50104 - (view) Author: Martin v. Löwis (loewis) Date: 2006-07-17 07:45
Logged In: YES 
user_id=21627

The patch is wrong; it breaks the existing test case
WeirdMetadataTest. I think the "just a single line" rule
should be restricted to Plural-Forms; not sure whether it
should apply to content-type also (but why not).

I'll attach another patch that adds a test case.
msg50105 - (view) Author: Martin v. Löwis (loewis) Date: 2006-08-25 00:13
Logged In: YES 
user_id=21627

Couldn't get to it before 2.5; forwarding to 2.4.4/2.5.1
History
Date User Action Args
2009-03-21 02:21:01ajaksu2setstage: patch review
type: behavior
versions: + Python 2.6, Python 3.1
2009-03-21 02:20:00ajaksu2linkissue1448060 dependencies
2006-04-24 13:09:38sytcreate