classification
Title: py3k-pep3137: patch for mailbox
Type: behavior Stage:
Components: Library (Lib) Versions: Python 3.0
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: akuchling Nosy List: akuchling, christian.heimes, gvanrossum, twouters
Priority: normal Keywords: patch

Created on 2007-11-06 11:37 by christian.heimes, last changed 2008-01-06 22:29 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
py3k-pep3137_fix_mailbox.patch christian.heimes, 2007-11-06 11:37
Messages (6)
msg57158 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2007-11-06 11:37
Hi Yhg1s!

svn praise shows your name for Lib/mailbox.py more often then other
names. Can you look at my patch and see if it's correct? It fixes most
of the errors in test_mailbox.py and all tests in test_old_mailbox. I'm
unsure about the patch.

Crys
msg57168 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2007-11-06 17:51
If Yhgls is twouters, I think he's on vacation.  Possibly Thomas appears
on the blame list because he did some big integrations.  Is he on the
blame list for the trunk as well?

Anyway I want this over with so I'll look into it.
msg57170 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2007-11-06 18:15
Yes, Yhg1s is Thomas nick on #python.

On the trunk svn annotate shows Andrew as the author of most lines.
Maybe he can shed some light on the problem. I'm not familiar with the
details of the mailbox format.
msg57172 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2007-11-06 18:34
I'm not following Py3K development at all, but the patch is pretty short
and seems reasonable.  I think mailboxes should be 7-bit clean in
theory, but have no idea if things are that tidy in practice.
msg57174 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2007-11-06 18:47
Thanks for your insight, Andrew! Applied in r58881. 

I agree with you but I'm not able to test it with real data. I've no
longer access to our old server at my old dormitory. I had a Qmail
system with maildir there. 

Two tests are still failing with the same error:
======================================================================
FAIL: test_get (test.test_mailbox.TestMaildir)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/heimes/dev/python/py3k-pep3137/Lib/test/test_mailbox.py",
line 138, in test_get
    self.assertEqual(msg.fp.read(), '1')
AssertionError: '\n\n1' != '1'
msg57175 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2007-11-06 18:57
I fixed the remaining two errors in r58882.
History
Date User Action Args
2008-01-06 22:29:45adminsetkeywords: - py3k
versions: Python 3.0
2007-11-06 18:57:58gvanrossumsetmessages: + msg57175
2007-11-06 18:47:10christian.heimessetstatus: open -> closed
resolution: fixed
messages: + msg57174
2007-11-06 18:34:04akuchlingsetmessages: + msg57172
2007-11-06 18:15:32christian.heimessetassignee: twouters -> akuchling
messages: + msg57170
nosy: + akuchling
2007-11-06 17:51:45gvanrossumsetnosy: + gvanrossum
messages: + msg57168
2007-11-06 11:37:58christian.heimescreate